+//------------------------------------------------------------------------------
+//------------------------------------------------------ Message::setFailedAvp()
+//------------------------------------------------------------------------------
+Avp * Message::setFailedAvp(AvpId id) throw(anna::RuntimeException) {
+
+ if(isRequest()) return NULL;
+
+// RFC 6733:
+//
+// 7.5. Failed-AVP AVP
+//
+// The Failed-AVP AVP (AVP Code 279) is of type Grouped and provides
+// debugging information in cases where a request is rejected or not
+// fully processed due to erroneous information in a specific AVP. The
+// value of the Result-Code AVP will provide information on the reason
+// for the Failed-AVP AVP. A Diameter answer message SHOULD contain an
+// instance of the Failed-AVP AVP that corresponds to the error
+// indicated by the Result-Code AVP. For practical purposes, this
+// Failed-AVP would typically refer to the first AVP processing error
+// that a Diameter node encounters.
+
+ // Although the Failed-AVP definition has cardinality 1* and Failed-AVP itself is defined in
+ // most of the command codes as *[Failed-AVP], i think this is not a deliberate ambiguity.
+ // Probably the RFC wants to give freedom to the application layer, but it is recommended to
+ // have only one child (wrong avp) inside a unique message Failed-AVP to ease the Result-Code
+ // correspondence. Anyway, this behaviour could be easily opened commenting condition block (*).
+ Avp *theFailedAvp = addTheFailedAVP();
+ LOGDEBUG(
+ std::string msg = "Adding wrong avp ";
+ msg += anna::diameter::functions::avpIdAsPairString(id);
+ msg += " within the message Failed-AVP ...";
+ anna::Logger::debug(msg, ANNA_FILE_LOCATION);
+ );
+
+ if (theFailedAvp->countChilds()) { // (*)
+ LOGDEBUG(anna::Logger::debug("Discarding wrong avp. A previous wrong avp was already added into the Failed-AVP. RFC 6733 Section 7.5 recommends to store only the first.", ANNA_FILE_LOCATION));
+ return NULL;
+ }
+
+ return (theFailedAvp->addAvp(id));
+}
+
+
+//------------------------------------------------------------------------------
+//------------------------------------------------------ Message::setFailedAvp()
+//------------------------------------------------------------------------------
+Avp * Message::setFailedAvp(Avp *avp) throw(anna::RuntimeException) {
+
+ if(!avp || isRequest()) return NULL;
+
+ Avp *theFailedAvp = addTheFailedAVP();
+ LOGDEBUG(
+ std::string msg = "Adding wrong avp ";
+ msg += anna::diameter::functions::avpIdAsPairString(avp->getId());
+ msg += " within the message Failed-AVP ...";
+ anna::Logger::debug(msg, ANNA_FILE_LOCATION);
+ );
+
+ if (theFailedAvp->countChilds()) { // (*)
+ LOGDEBUG(anna::Logger::debug("Discarding wrong avp. A previous wrong avp was already added into the Failed-AVP. RFC 6733 Section 7.5 recommends to store only the first.", ANNA_FILE_LOCATION));
+ return NULL;
+ }
+
+ return (theFailedAvp->addAvp(avp));
+}
+
+
projects / anna.git / commitdiff