From 93ddfd21d4b502cd79b0d36e14518fbbde5982b2 Mon Sep 17 00:00:00 2001 From: "Eduardo Ramos Testillano (eramedu)" Date: Thu, 14 May 2020 15:31:25 +0200 Subject: [PATCH] Remove mark as xfail for some tests As we are launching pytest from ct.sh script, service is always available when running the component tests. Then, these tests are not going to fail. --- .../resources/rest_api/ct/flow-operations/sendhex_test.py | 4 ++-- .../resources/rest_api/ct/flow-operations/sendmsg_test.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendhex_test.py b/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendhex_test.py index a07b7c4..b5cbace 100644 --- a/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendhex_test.py +++ b/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendhex_test.py @@ -24,7 +24,7 @@ def test_001_given_diameter_hex_representation_i_want_to_send_message_to_diamete # IT FAILS BECAUSE MESSAGE SENT HAS OCS3 AS ORIGIN HOST, AND THIS IS NOT REGISTERED, SO node-auto COULD NOT DEDUCE THE CORRECT RESOURCE -@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") +#@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") def test_002_given_diameter_hex_representation_i_want_to_send_message_to_diameter_entity_and_check_it_succeed_for_correct_node(resources, admlc): requestBody = { "name":"afHost.afRealm.com" } @@ -48,7 +48,7 @@ def test_002_given_diameter_hex_representation_i_want_to_send_message_to_diamete # Verify response admlc.assert_response__status_body_headers(response, 200, responseBodyRef) -@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") +#@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") def test_003_given_diameter_hex_representation_i_want_to_send_message_to_diameter_client_and_check_it_succeed_for_correct_node(resources, admlc): # # WE HAVE TO CONFIGURE THE CLIENT AS OPERATED HOST, BECAUSE HEX SENDING PROCEDURE IS NOT GOING TO UPDATE OPERATED HOST WITH CODEC: diff --git a/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendmsg_test.py b/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendmsg_test.py index f3afa4c..48f333b 100644 --- a/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendmsg_test.py +++ b/example/diameter/launcher/resources/rest_api/ct/flow-operations/sendmsg_test.py @@ -21,7 +21,7 @@ def test_001_given_diameter_json_representation_i_want_to_send_message_to_diamet # IT FAILS BECAUSE MESSAGE SENT HAS OCS3 AS ORIGIN HOST, AND THIS IS NOT REGISTERED, SO node-auto COULD NOT DEDUCE THE CORRECT RESOURCE -@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") +#@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") def test_002_given_diameter_json_representation_i_want_to_send_message_to_diameter_entity_and_check_it_succeed_for_forced_node(resources, admlc): requestBody = { "name":"afHost.afRealm.com" } @@ -42,7 +42,7 @@ def test_002_given_diameter_json_representation_i_want_to_send_message_to_diamet ### Verify response admlc.assert_response__status_body_headers(response, 200, responseBodyRef) -@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") +#@pytest.mark.xfail(reason="Server must receive client connection to be available. Component test is very fast and this could fail the first time. Wait and test again. TODO: wait for available status after 'services' loading.") def test_003_given_diameter_json_representation_i_want_to_send_message_to_diameter_client_and_check_it_succeed_for_auto_node(resources, admlc): responseBodyRef = { "success":"true", "response":"Working node has been set to automatic" } -- 2.20.1