X-Git-Url: https://git.teslayout.com/public/public/public/?a=blobdiff_plain;f=include%2Fanna%2Fdiameter%2Fcodec%2FMessage.hpp;h=48d2b848342797fd75c8969fd8a67d64c54ba96c;hb=2921c651c9945cefec0715167201596aaa079e8d;hp=6ec6e3a620119899d2faaa0890b3d25dc51d8ae2;hpb=129af2a9a7c287843be5bd443c5b1ad9b08438a8;p=anna.git diff --git a/include/anna/diameter/codec/Message.hpp b/include/anna/diameter/codec/Message.hpp index 6ec6e3a..48d2b84 100644 --- a/include/anna/diameter/codec/Message.hpp +++ b/include/anna/diameter/codec/Message.hpp @@ -244,24 +244,26 @@ public: /** Sets/unsets E bit activation. Application should not have to use this because dictionary information is used in order to configure flags when Message identifier is stored. + This flag MUST NOT be set in request messages (in this case, it will be ignored). @param activate Activates/deactivates the bit. True by default. */ - void setErrorBit(bool activate = true) throw() { if(activate) a_flags |= EBitMask; else a_flags &= (~EBitMask); } + void setErrorBit(bool activate = true) throw() { if(isRequest()) return; if(activate) a_flags |= EBitMask; else a_flags &= (~EBitMask); } /** Sets/unsets T bit activation. Application should not have to use this because dictionary information is used in order to configure flags when Message identifier is stored. + This flag MUST NOT be set in answer messages (in this case, it will be ignored). @param activate Activates/deactivates the bit. True by default. */ - void setPotentiallyReTransmittedMessageBit(bool activate = true) throw() { if(activate) a_flags |= TBitMask; else a_flags &= (~TBitMask); } + void setPotentiallyReTransmittedMessageBit(bool activate = true) throw() { if(isAnswer()) return; if(activate) a_flags |= TBitMask; else a_flags &= (~TBitMask); } /** Sets the message application id. The codec engine could be configured to force a stack selection based in this field value: see #selectStackWithApplicationId. - In multistack applications (which also shall be monothreaded), you only have to take care about how to apply this method: the thing + In multistack applications (in case of being monothread), you only have to take care about how to apply this method: the thing is that you must not interleave message builds which belongs to different stacks. For example, you could think about setting the message header for message A using stack A. Then, start to add the message header fields for a second message B using another stack B. Following you would add the message A avps, but then, the stack is not going to be automatically changed (this is only done through this